Skip to content

Commit

Permalink
Update on "[ONNX] Add test_fx_op_consistency.py"
Browse files Browse the repository at this point in the history
Should be merged after #99434

[ghstack-poisoned]
  • Loading branch information
titaiwangms committed Apr 19, 2023
2 parents 7a3df0d + 7523cac commit f59c428
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 1 addition & 1 deletion test/onnx/test_fx_op_consistency.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def reason_flaky() -> str:
reason=reason_onnx_does_not_support("Ceil")
),
fixme("ceil", dtypes=[torch.float64], reason=reason_onnx_runtime_does_not_support("Ceil", ["f64"])),
xfail("unflatten", reason="AssertionError: Expected 1 inputs, got 3"),
xfail("unflatten", reason="AssertionError: Expected 1 inputs, got 3 (https://github.com/pytorch/pytorch/issues/99534)"),
)
# fmt: on

Expand Down
8 changes: 1 addition & 7 deletions test/onnx/test_fx_to_onnx_with_onnxruntime.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,7 @@ def func(x, b=torch.tensor(1.0)):
# parameter input_value=8.0 violates type hint typing.Union[torch.Tensor, NoneType],
# as float 8.0 not <class "builtins.NoneType"> or <protocol "torch.Tensor">.
# @unittest.expectedFailure
@pytorch_test_common.xfail(
"beartype.roar.BeartypeCallHintReturnViolation: @beartyped "
"torch.onnx._internal.exporter.ExportOutput.adapt_torch_inputs_to_onnx() "
"return (tensor([[[ 1.5410, -0.2934]]]), 8.0) violates type hint "
"typing.Sequence[torch.Tensor], as tuple index 1 item float 8.0 not "
"instance of <protocol 'torch.Tensor'>."
)
@pytorch_test_common.xfail("https://github.com/pytorch/pytorch/issues/99534")
@pytorch_test_common.skip_min_ort_version(
reason="ORT doesn't support dynamic fx exporter yet making SegFault flaky test",
version="1.15",
Expand Down

0 comments on commit f59c428

Please sign in to comment.