Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamo] Support several missing torch.* ops #102340

Closed
yanboliang opened this issue May 26, 2023 · 2 comments
Closed

[Dynamo] Support several missing torch.* ops #102340

yanboliang opened this issue May 26, 2023 · 2 comments
Assignees
Labels
module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@yanboliang
Copy link
Contributor

yanboliang commented May 26, 2023

馃悰 Describe the bug

This is the list of torch.* ops that we are missing support, but was used frequently in 14k github models:

  • torch.is_complex
  • torch.get_autocast_gpu_dtype
  • torch.nn.init._calculate_correct_fan

Versions

N/A

cc @ezyang @msaroufim @wconstab @ngimel @bdhirsh @anijain2305 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx

@yanboliang yanboliang added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module oncall: pt2 module: dynamo labels May 26, 2023
@fduwjj fduwjj self-assigned this Jun 6, 2023
@yanboliang
Copy link
Contributor Author

For torch.nn.init._calculate_correct_fan we should add support under TorchVariable.call_function and compute the result during compilation. It's a bit complicated, so we can skip it for the hackday task.

@fduwjj
Copy link
Contributor

fduwjj commented Jun 7, 2023

Hi, @yanboliang do you mean something like

result = TorchVariable(torch.mul, **options).call_function( tx, [result, kwargs["value"]], {} )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
2 participants