New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeError: Undefined type BFloat16 from matmul above certain sizes (maybe MPS only) #121583
Labels
module: bfloat16
module: mps
Related to Apple Metal Performance Shaders framework
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
Comments
1 task
albanD
added
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
module: bfloat16
module: mps
Related to Apple Metal Performance Shaders framework
labels
Mar 11, 2024
Ok, I know the problem: MPS supports BFloat16, but metal is not, and as MPS matmul is buggy for large matrices, there is a naive Metal matmul implementation, that yet not support bf16 |
malfet
added a commit
that referenced
this issue
Mar 12, 2024
Will only work on MacOS14 or newer, so compile the shader with `MTLLanguageVersion_3_1` when appropriate Fixes #121583
malfet
added a commit
that referenced
this issue
Mar 12, 2024
Will only work on MacOS14 or newer, so compile the shader with `MTLLanguageVersion_3_1` when appropriate Fixes #121583
malfet
added a commit
that referenced
this issue
Mar 13, 2024
Will only work on MacOS14 or newer, so compile the shader with `MTLLanguageVersion_3_1` when appropriate Fixes #121583
pytorchbot
pushed a commit
that referenced
this issue
Apr 3, 2024
Will only work on MacOS14 or newer, so compile the shader with `MTLLanguageVersion_3_1` when appropriate Fixes #121583 Pull Request resolved: #121731 Approved by: https://github.com/albanD (cherry picked from commit 5498804)
atalman
pushed a commit
that referenced
this issue
Apr 4, 2024
Will only work on MacOS14 or newer, so compile the shader with `MTLLanguageVersion_3_1` when appropriate Fixes #121583 Pull Request resolved: #121731 Approved by: https://github.com/albanD (cherry picked from commit 5498804) Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
validated with 2.3:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: bfloat16
module: mps
Related to Apple Metal Performance Shaders framework
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
馃悰 Describe the bug
When using torch.matmul (and the @ operator) on bfloat16 tensors above a certain size I'm getting the error
RuntimeError: Undefined type BFloat16
Example code
results in
Versions
cc @kulinseth @albanD @malfet @DenisVieriu97 @razarmehr
The text was updated successfully, but these errors were encountered: