Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISABLED test_hparams_bool (__main__.TestTensorBoardSummary) #121927

Closed
malfet opened this issue Mar 14, 2024 · 1 comment
Closed

DISABLED test_hparams_bool (__main__.TestTensorBoardSummary) #121927

malfet opened this issue Mar 14, 2024 · 1 comment
Labels
module: macos Mac OS related issues module: tensorboard skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@malfet
Copy link
Contributor

malfet commented Mar 14, 2024 •
edited by pytorch-bot bot

Platforms: macos, mac

This test was disabled because it is failing on main branch (recent examples).

cc @albanD
@pytorch-bot pytorch-bot bot added the skipped Denotes a (flaky) test currently skipped in CI. label Mar 14, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 14, 2024 •
edited

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_hparams_bool (__main__.TestTensorBoardSummary)
  • Platforms for which to skip the test: mac, macos
  • Disabled by malfet

Within ~15 minutes, test_hparams_bool (__main__.TestTensorBoardSummary) will be disabled in PyTorch CI for these platforms: mac, macos. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

@huydhn huydhn mentioned this issue Mar 14, 2024
Closed
@pytorch-bot pytorch-bot bot added the module: macos Mac OS related issues label Mar 14, 2024
@huydhn huydhn mentioned this issue Mar 15, 2024
Closed
@janeyx99 janeyx99 added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: tensorboard labels Mar 15, 2024
This was referenced Mar 16, 2024
Closed
Closed
pytorchbot pushed a commit that referenced this issue Mar 19, 2024
@huydhn @pytorchbot
Pin protobuf to 3.20.2 on macOS (#121918)
c310e90 
The newer protobuf 5.26.0 releasing on March 13rd is causing failures with `test_hparams_*` from `test_tensorboard` in which the stringify metadata is wrong when escaping double quote. For example, https://hud.pytorch.org/pytorch/pytorch/commit/3bc2bb678150e02bfa2552b82572d771a892d0c3.  This looks like an upstream issue from Tensorboard where it doesn't work with this brand new protobuf version https://github.com/tensorflow/tensorboard/blob/master/tensorboard/pip_package/requirements.txt#L29

The package has been pinned on Docker https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L155, so it should be pinned on macOS too.  We want to eventually just have one requirements.txt file.

Fixes #122008
Fixes #121927
Fixes #121946
Pull Request resolved: #121918
Approved by: https://github.com/kit1980

(cherry picked from commit 5f601a4)
@pytorchbot pytorchbot mentioned this issue Mar 19, 2024
Merged
huydhn added a commit that referenced this issue Mar 19, 2024
@pytorchbot @huydhn
Pin protobuf to 3.20.2 on macOS (#121918) (#122207)
9e6f42d 
The newer protobuf 5.26.0 releasing on March 13rd is causing failures with `test_hparams_*` from `test_tensorboard` in which the stringify metadata is wrong when escaping double quote. For example, https://hud.pytorch.org/pytorch/pytorch/commit/3bc2bb678150e02bfa2552b82572d771a892d0c3.  This looks like an upstream issue from Tensorboard where it doesn't work with this brand new protobuf version https://github.com/tensorflow/tensorboard/blob/master/tensorboard/pip_package/requirements.txt#L29

The package has been pinned on Docker https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L155, so it should be pinned on macOS too.  We want to eventually just have one requirements.txt file.

Fixes #122008
Fixes #121927
Fixes #121946
Pull Request resolved: #121918
Approved by: https://github.com/kit1980

(cherry picked from commit 5f601a4)

Co-authored-by: Huy Do <huydhn@gmail.com>
huydhn added a commit that referenced this issue Apr 2, 2024
@huydhn
Pin protobuf to 3.20.2 on macOS (#121918)
e22e17e 
The newer protobuf 5.26.0 releasing on March 13rd is causing failures with `test_hparams_*` from `test_tensorboard` in which the stringify metadata is wrong when escaping double quote. For example, https://hud.pytorch.org/pytorch/pytorch/commit/3bc2bb678150e02bfa2552b82572d771a892d0c3.  This looks like an upstream issue from Tensorboard where it doesn't work with this brand new protobuf version https://github.com/tensorflow/tensorboard/blob/master/tensorboard/pip_package/requirements.txt#L29

The package has been pinned on Docker https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L155, so it should be pinned on macOS too.  We want to eventually just have one requirements.txt file.

Fixes #122008
Fixes #121927
Fixes #121946
Pull Request resolved: #121918
Approved by: https://github.com/kit1980
atalman pushed a commit that referenced this issue Apr 2, 2024
@huydhn
Pin protobuf to 3.20.2 on macOS (#123197)
8194fae 
The newer protobuf 5.26.0 releasing on March 13rd is causing failures with `test_hparams_*` from `test_tensorboard` in which the stringify metadata is wrong when escaping double quote. For example, https://hud.pytorch.org/pytorch/pytorch/commit/3bc2bb678150e02bfa2552b82572d771a892d0c3.  This looks like an upstream issue from Tensorboard where it doesn't work with this brand new protobuf version https://github.com/tensorflow/tensorboard/blob/master/tensorboard/pip_package/requirements.txt#L29

The package has been pinned on Docker https://github.com/pytorch/pytorch/blob/main/.ci/docker/requirements-ci.txt#L155, so it should be pinned on macOS too.  We want to eventually just have one requirements.txt file.

Fixes #122008
Fixes #121927
Fixes #121946
Pull Request resolved: #121918
Approved by: https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: macos Mac OS related issues module: tensorboard skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin protobuf to 3.20.2 on macOS huydhn/pytorch
2 participants
@malfet @janeyx99