-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch.compile
is not usable on MacOS out of box
#122705
Comments
Maybe a better error msg "please install openmp via conda" would help |
Ok, I tried with downloading a nightly locally, and I did get a warning msg,
Not sure how to reproduce @malfet 's problem. |
Hmm, omp.h should have been bundled with torch wheel, see Line 564 in e3d80f2
But indeed, I don't see it there:
But the same works for 2.3.0-RC1:
|
Also, move to M1 mac (by adding macos-14 to the matrix), but right now it's blocked by pytorch/pytorch#123225 and pytorch/pytorch#122705 (though later is occluded by pipe redirect)
Grabbing for myself, as right now it's a packaging problem: we ship with libomp.dylib twice |
@atalman fyi
|
cc @malfet Looks like its looking in completely different path:
doing
|
To prevent delocate from double-packing it, which makes Torch wheels unusable with torch.compile out of the box Fixes #122705
Please note. The packaging of libomp.dylib twice, exist only in trunk, currently. Release 2.3.0 seems not to be affected. This seems like 2 different problems: |
To prevent delocate from double-packing it, which makes Torch wheels unusable with torch.compile out of the box Fixes #122705 Pull Request resolved: #123417 Approved by: https://github.com/atalman (cherry picked from commit 5b0ce8f)
To prevent delocate from double-packing it, which makes Torch wheels unusable with torch.compile out of the box Fixes pytorch#122705 Pull Request resolved: pytorch#123417 Approved by: https://github.com/atalman
To prevent delocate from double-packing it, which makes Torch wheels unusable with torch.compile out of the box Fixes #122705 Pull Request resolved: #123417 Approved by: https://github.com/atalman Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
To prevent delocate from double-packing it, which makes Torch wheels unusable with torch.compile out of the box Fixes pytorch#122705 Pull Request resolved: pytorch#123417 Approved by: https://github.com/atalman
Also, move to M1 mac (by adding macos-14 to the matrix), but right now it's blocked by pytorch/pytorch#123225 and pytorch/pytorch#122705 (though later is occluded by pipe redirect)
Also, move to M1 mac (by adding macos-14 to the matrix), but right now it's blocked by pytorch/pytorch#123225 and pytorch/pytorch#122705 (though later is occluded by pipe redirect)
Also, move to M1 mac (by adding macos-14 to the matrix), but right now it's blocked by pytorch/pytorch#123225 and pytorch/pytorch#122705 (though later is occluded by pipe redirect)
🐛 Describe the bug
Attempts to run any
torch.compile
d code fails out-of-box with 2.3.0 wheels, as it attempts to link against wrong copy oflibomp.dylib
:This happens, because
delocate
embeds libomp.dylib intotorch/.dylibs
folder, but another instance is shipped intorch/libs
Versions
2.3.0
cc @ezyang @gchanan @zou3519 @kadeng @seemethere @osalpekar @atalman @albanD @msaroufim @bdhirsh @anijain2305 @chauhang
The text was updated successfully, but these errors were encountered: