Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamo] Fix refleak in 3.12+ and Dynamic Shapes test_parameter_free #124302

Open
williamwen42 opened this issue Apr 17, 2024 · 1 comment
Open

[Dynamo] Fix refleak in 3.12+ and Dynamic Shapes test_parameter_free #124302

williamwen42 opened this issue Apr 17, 2024 · 1 comment
Assignees
@williamwen42
Labels
module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@williamwen42
Copy link
Member

williamwen42 commented Apr 17, 2024 •
edited by pytorch-bot bot

The test_parameter_free test in test/dynamo/test_misc.py is failing on Python 3.12 and on dynamic shapes.

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng
@williamwen42 williamwen42 added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module oncall: pt2 module: dynamo labels Apr 17, 2024
@williamwen42 williamwen42 self-assigned this Apr 17, 2024
@williamwen42 williamwen42 mentioned this issue Apr 17, 2024
Closed
@williamwen42
Copy link
Member Author

Confirmed that if one comments out @functools.lru_cache() from _shadowed_dict_from_mro_tuple in inspect.py, the test passes.

@williamwen42 williamwen42 mentioned this issue Apr 26, 2024
Closed
williamwen42 added a commit that referenced this issue Apr 26, 2024
@williamwen42
Update on "[dynamo, 3.12] xfail refleaking tests due to buggy getattr…
ae20159 
…_static"


For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
williamwen42 added a commit that referenced this issue Apr 29, 2024
@williamwen42
Update base for Update on "[dynamo, 3.12] xfail refleaking tests due …
e7ff4b6 
…to buggy getattr_static"


For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
williamwen42 added a commit that referenced this issue Apr 29, 2024
@williamwen42
Update on "[dynamo, 3.12] xfail refleaking tests due to buggy getattr…
2df19ac 
…_static"


For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
williamwen42 added a commit that referenced this issue Apr 30, 2024
@williamwen42
Update base for Update on "[dynamo, 3.12] xfail refleaking tests due …
e5d9b5c 
…to buggy getattr_static"


For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
williamwen42 added a commit that referenced this issue Apr 30, 2024
@williamwen42
Update on "[dynamo, 3.12] xfail refleaking tests due to buggy getattr…
14f1559 
…_static"


For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Apr 30, 2024
@williamwen42 @pytorchmergebot
[dynamo, 3.12] xfail refleaking tests due to buggy getattr_static (#1…
d6c7138 
…25062)

For tracking #124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

Pull Request resolved: #125062
Approved by: https://github.com/anijain2305, https://github.com/jansel
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this issue May 1, 2024
@williamwen42 @facebook-github-bot
xfail refleaking tests due to buggy getattr_static (#125062)
b85b0b6 
Summary:
For tracking pytorch/pytorch#124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

X-link: pytorch/pytorch#125062
Approved by: https://github.com/anijain2305, https://github.com/jansel

Reviewed By: kit1980

Differential Revision: D56801860

Pulled By: williamwen42

fbshipit-source-id: 16b38ce7f1b8cabe2fcdd660fc8a2fabdda04aca
andoorve pushed a commit to andoorve/pytorch that referenced this issue May 1, 2024
@williamwen42 @andoorve
[dynamo, 3.12] xfail refleaking tests due to buggy getattr_static (py…
6b06c96 
…torch#125062)

For tracking pytorch#124302 so that we can re-enable the test once 3.12 updates with the bug fix for python/cpython#118013.

Pull Request resolved: pytorch#125062
Approved by: https://github.com/anijain2305, https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamwen42 williamwen42

Labels
module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williamwen42