Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate 'NoneType' object has no attribute 'mutable_local' when nn module inlining enabled. #125315

Closed
laithsakka opened this issue May 1, 2024 · 0 comments

Comments

@laithsakka
Copy link
Contributor

laithsakka commented May 1, 2024

@laithsakka laithsakka self-assigned this May 1, 2024
laithsakka added a commit that referenced this issue May 1, 2024
#fix #125315

Several failures when inlining nn module is enabled are due to passing None to has_pending_mutation 
from previous code, it sounds like its expected for variable to be none when not found, In that case we should skip it and not call has_pending_mutation
this is tested in #125354



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
laithsakka added a commit that referenced this issue May 1, 2024
#fix #125315

Several failures when inlining nn module is enabled are due to passing None to has_pending_mutation 
from previous code, it sounds like its expected for variable to be none when not found, In that case we should skip it and not call has_pending_mutation
this is tested in #125354



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
pytorch-bot bot pushed a commit that referenced this issue May 3, 2024
#fix #125315

Several failures when inlining nn module is enabled are due to passing None to has_pending_mutation
from previous code, it sounds like its expected for variable to be none when not found, In that case we should skip it and not call has_pending_mutation
this is tested in #125354

Pull Request resolved: #125359
Approved by: https://github.com/mlazos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants