Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations for util.data missing #18725

Closed
malmaud opened this issue Apr 2, 2019 · 1 comment
Closed

Type annotations for util.data missing #18725

malmaud opened this issue Apr 2, 2019 · 1 comment
Assignees
@malmaud
Labels
high priority module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@malmaud
Copy link
Contributor

malmaud commented Apr 2, 2019

馃殌 Feature

cf #16996
@ezyang ezyang added module: typing Related to mypy type annotations high priority triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 2, 2019
@malmaud
Copy link
Contributor Author

malmaud commented Apr 3, 2019 •
edited
Loading

I'm mostly done with this, I'll submit a PR soon.

@malmaud malmaud mentioned this issue Apr 5, 2019
Closed
zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this issue May 6, 2019
@malmaud
Type annotations for util.data. (pytorch#18963)
0847f4a 
Summary:
I haven't had a chance to rigorously try these out yet so don't merge yet.
Closes pytorch#18725.
Pull Request resolved: pytorch#18963

Differential Revision: D14832897

Pulled By: ezyang

fbshipit-source-id: 4780e7a34126bc66ddbfd9d808dfc9e0edd77e68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malmaud malmaud

Labels
high priority module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type annotations for util.data. malmaud/pytorch
2 participants
@ezyang @malmaud