Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title of docs page includes "PyTorch master documentation" even for non-master branches. #21290

Open
umanwizard opened this issue Jun 3, 2019 · 1 comment
Open

Title of docs page includes "PyTorch master documentation" even for non-master branches. #21290

umanwizard opened this issue Jun 3, 2019 · 1 comment
Labels
module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@umanwizard
Copy link
Contributor

umanwizard commented Jun 3, 2019 •
edited

E.g. go to https://pytorch.org/docs/stable/ and look at the HTML title of the page. It is PyTorch documentation — PyTorch master documentation
@umanwizard umanwizard added the module: docs Related to our documentation, both in docs/ and docblocks label Jun 3, 2019
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 4, 2019
@jerryzh168
Copy link
Contributor

The suggestion looks reasonable. We would accept a patch that fixes this.

@JamesTrick JamesTrick mentioned this issue Sep 12, 2019
Closed
@glaringlee glaringlee mentioned this issue May 8, 2020
Closed
glaringlee added a commit that referenced this issue May 8, 2020
@glaringlee
Update on "use version number instead of 'master' in html header title"
fe65322 
This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get 
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

[ghstack-poisoned]
glaringlee added a commit that referenced this issue May 10, 2020
@glaringlee
Update on "use version number instead of 'master' in html header title"
2f0d3d9 
This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get 
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

[ghstack-poisoned]
glaringlee added a commit that referenced this issue May 15, 2020
@glaringlee
Update on "use version number instead of 'master' in html header title"
63c6944 
This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get 
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

[ghstack-poisoned]
glaringlee pushed a commit that referenced this issue May 15, 2020
Update on "use version number instead of 'master' in html header title"
781e644 
This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get 
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

Differential Revision: [D21586559](https://our.internmc.facebook.com/intern/diff/D21586559)

[ghstack-poisoned]
glaringlee added a commit that referenced this issue May 15, 2020
@glaringlee
Update on "use version number instead of 'master' in html header title"
361bffb 
This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get 
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

Differential Revision: [D21586559](https://our.internmc.facebook.com/intern/diff/D21586559)

[ghstack-poisoned]
glaringlee added a commit that referenced this issue May 15, 2020
@glaringlee
Update on "use version number instead of 'master' in html header title"
dd47244 
This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get 
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

Differential Revision: [D21586559](https://our.internmc.facebook.com/intern/diff/D21586559)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this issue May 15, 2020
@glaringlee @facebook-github-bot
use version number instead of 'master' in html header title (#38149)
52e9953 
Summary:
Pull Request resolved: #38149

This is for (#21290) (#31894)

Instead of putting "Pytorch master documentation" in header's html title, now we use "Pytorch 1.x.x documentation", this is similar to tensorFlow and numpy doc page.

In google search, we will get
Pytorch Documentation - Pytorch 1.x.x Documentation instead.

Test Plan: Imported from OSS

Differential Revision: D21586559

Pulled By: glaringlee

fbshipit-source-id: 2995709ac3c22dbb0183b5b4abfde7d795f1f8eb
@glaringlee glaringlee mentioned this issue May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@umanwizard @jerryzh168