Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box constraints for optimizers #22281

Open
vincentqb opened this issue Jun 26, 2019 · 4 comments
Open

Box constraints for optimizers #22281

vincentqb opened this issue Jun 26, 2019 · 4 comments
Labels
feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@vincentqb
Copy link
Contributor

vincentqb commented Jun 26, 2019

馃殌 Feature

Offer the option to set box constraints for optimizers.

Motivation

In some applications of reinforcement learning, falling outside of a region correspond to inadmissible actions.

Alternatives

One can omit the constraints, and hope that the optimal parameters found happen to be within the constraints, without any guarantees.

Additional context

This was suggested in #938 for torch.optim.lbfgs.

CC @bamos

@ailzhang ailzhang added feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 27, 2019
@vincentqb
Copy link
Contributor Author

vincentqb commented Jul 9, 2019

Superset of #6564

@vincentqb vincentqb marked this as a duplicate of #6564 Jul 9, 2019
@vincentqb vincentqb marked this as not a duplicate of #6564 Jul 9, 2019
@vincentqb vincentqb reopened this Jul 9, 2019
@eric-tramel
Copy link

eric-tramel commented Jul 15, 2020

Thanks for this superset of the box-constraint feature request on LBFGS (i.e. LBFGS-B) @vincentqb . The contributed #938 was closed for being stale and also not the correct solution. However, this feature would be very useful for some inverse image reconstruction problems (used in privacy analysis of DCNNs, for example).

Should one attempt to resurrect the old #938 and address your concerns (correct implementation, align with current state of the code, etc.) in a followup PR specific for LBFGS, or are you looking for contributions only to address the more meta-challenge of box-constraints across all optimizers?

@nikitaved
Copy link
Collaborator

nikitaved commented Jul 15, 2020

If there are no other volunteers, I would love to work on this after I am done with functions of a matrix. I used a box-constrained Newton in my research, based on the method by Bertsekas, which I had to implement from scratch, so it should not take that much time...

@nsakhanenko
Copy link

Has there been any progress in adding bounds to LBFGS (LBFGS-B) in pytorch? It would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

5 participants