Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsqueeze has 'out=' option documented but not implemented(?) #29800

Open
meganset opened this issue Nov 14, 2019 · 1 comment
Open

unsqueeze has 'out=' option documented but not implemented(?) #29800

meganset opened this issue Nov 14, 2019 · 1 comment
Labels
module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@meganset
Copy link
Contributor

馃摎 Documentation

I think the documentation shouldn't include an out= option,
I don't see any unsqueeze_out() function in ATen..

>>> torch.unsqueeze(torch.tensor([1,2.0]),-1,out=r)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: unsqueeze() got an unexpected keyword argument 'out'
@ailzhang ailzhang added the module: docs Related to our documentation, both in docs/ and docblocks label Nov 14, 2019
@ailzhang
Copy link
Contributor

@meganset We'll happily accept a PR to correct the documentation. Would you mind sending one? Thanks!

@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 14, 2019
@matthew-haines matthew-haines mentioned this issue Feb 19, 2020
Closed
facebook-github-bot pushed a commit that referenced this issue Feb 19, 2020
@matthew-haines @facebook-github-bot
Correct documentation for torch.unsqueeze (#33478)
1d9fcf8 
Summary:
"out" argument in torch.unsqueeze is not actually implemented, fixed documentation #29800
After: ![image](https://user-images.githubusercontent.com/33493903/74796371-6289ee00-5296-11ea-8493-e8c18ac63bdf.png)

Before: ![image](https://user-images.githubusercontent.com/33493903/74796444-96651380-5296-11ea-816c-2adacfa79e35.png)
Pull Request resolved: #33478

Differential Revision: D19978477

Pulled By: yf225

fbshipit-source-id: 42337326c1ec04975307366c94591ee32a11b091
ttumiel pushed a commit to ttumiel/pytorch that referenced this issue Mar 4, 2020
@matthew-haines @ttumiel
Correct documentation for torch.unsqueeze (pytorch#33478)
c3228db 
Summary:
"out" argument in torch.unsqueeze is not actually implemented, fixed documentation pytorch#29800
After: ![image](https://user-images.githubusercontent.com/33493903/74796371-6289ee00-5296-11ea-8493-e8c18ac63bdf.png)

Before: ![image](https://user-images.githubusercontent.com/33493903/74796444-96651380-5296-11ea-816c-2adacfa79e35.png)
Pull Request resolved: pytorch#33478

Differential Revision: D19978477

Pulled By: yf225

fbshipit-source-id: 42337326c1ec04975307366c94591ee32a11b091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ailzhang @meganset