Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of requiring to do super.__init__ in nn.Container subclasses #422

Closed
soumith opened this issue Jan 9, 2017 · 1 comment
Closed

get rid of requiring to do super.__init__ in nn.Container subclasses #422

soumith opened this issue Jan 9, 2017 · 1 comment

Comments

@soumith
Copy link
Member

soumith commented Jan 9, 2017

This seems like its something that users'll forget to do, and we might get a lot of subtle bug reports because of this. Seems like a good usability fix early on.
@apaszke
Copy link
Contributor

apaszke commented Jan 20, 2017 •
edited

Right now if you try to assign any module or parameter to a nn.Module without calling super().__init__() it will raise a clear error. Since I can't think of any cases when you don't do this in __init__ I'm closing this issue.

@apaszke apaszke closed this as completed Jan 20, 2017
mrshenli pushed a commit to mrshenli/pytorch that referenced this issue Apr 11, 2020
@yf225
[v1.0.1] cpp tutorial fix (pytorch#422)
8aefdf5 
* fix Normalize

* fix data_loader

* [WIP]

* fix torch_script_custom_ops
jjsjann123 pushed a commit to jjsjann123/pytorch that referenced this issue Oct 16, 2020
@naoyam
Bug fix (pytorch#422)
4243378
KyleCZH pushed a commit to KyleCZH/pytorch that referenced this issue Sep 20, 2021
@peterjc123
Use sccache-cl instead of sccache (pytorch#422)
d5a1241
eellison pushed a commit to eellison/pytorch that referenced this issue Jun 29, 2022
@pyjhzwh
[Inductor] Triton template for conv (pytorch#422)
20e8e04 
* TritonTemplateKernel, template_codegen, conv jinja2 template
* pip install Jinja2 in setup_nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soumith @apaszke