Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META] Assert that expected libraries appear in libtorch #46464

Open
erip opened this issue Oct 16, 2020 · 0 comments
Open

[META] Assert that expected libraries appear in libtorch #46464

erip opened this issue Oct 16, 2020 · 0 comments
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: static linking Related to statically linked libtorch (we dynamically link by default) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@erip
Copy link
Contributor

erip commented Oct 16, 2020 •
edited

馃殌 Feature

We should create an expected list of files to appear in libtorch to test that libtorch was build correctly.

Motivation

With #44257, we should expect that pytorch_jni libs appear in libtorch bundles on all platforms. This currently doesn't happen because of upstream cmake issues in fbjni.

Pitch

To make sure that upstream issues don't silently cause issues in libtorch, we should create a post-build test which ensures that expected files appear in the bundle.

Alternatives

Status quo.
@erip erip mentioned this issue Oct 16, 2020
Closed
@ailzhang ailzhang added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: static linking Related to statically linked libtorch (we dynamically link by default) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 16, 2020
@Dris101 Dris101 mentioned this issue Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: static linking Related to statically linked libtorch (we dynamically link by default) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erip @ailzhang