Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch_jni.dll and pytorch_jni.lib missing from LibTorch Windows zip archives after 1.10.2 #86536

Closed
Dris101 opened this issue Oct 8, 2022 · 3 comments
Closed

pytorch_jni.dll and pytorch_jni.lib missing from LibTorch Windows zip archives after 1.10.2 #86536

Dris101 opened this issue Oct 8, 2022 · 3 comments
Assignees
@cristianPanaite
Labels
module: windows Windows support for PyTorch oncall: java triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@Dris101
Copy link

Dris101 commented Oct 8, 2022 •
edited by pytorch-bot bot

馃悰 Describe the bug

pytorch_jni.dll and pytorch_jni.lib are missing from the lib directory in the LibTorch bundles for Windows after 1.10.2

See for example:-
1.12.1 CUDA 11.6 Archive et al. and, as of writing, current nightly

See also:-

#78483
#46464

This breaks the Java TorchScript bindings unfortunately

Versions

LibTorch > 1.10.2

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm
@Dris101 Dris101 changed the title pytorch_jni.dll and pytorch_jni.lib missing from LibTorch Windows zip archives since 1.10.2 pytorch_jni.dll and pytorch_jni.lib missing from LibTorch Windows zip archives after 1.10.2 Oct 8, 2022
@malfet malfet added module: windows Windows support for PyTorch oncall: java triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 10, 2022
@malfet
Copy link
Contributor

malfet commented Oct 10, 2022

Thank you for reporting the issue. Will accept the PR that fixes the issues

@cristianPanaite cristianPanaite mentioned this issue Jan 26, 2023
Closed
@cristianPanaite
Copy link
Collaborator

Hello @Dris101,

I just made a PR that should solve this issue. @malfet Can you help me with it? #93057

@Dris101
Copy link
Author

Dris101 commented Jan 29, 2023

Hi @cristianPanaite. I'm seeing those dlls in the nightlies now. Thanks very much for your help! My build-foo is not up to fixing that!

@hakanai hakanai mentioned this issue Feb 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristianPanaite cristianPanaite

Labels
module: windows Windows support for PyTorch oncall: java triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
PyTorch On Windows
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Repair the path to jni.h for libtorch windows build
3 participants
@malfet @Dris101 @cristianPanaite