Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable torch.nn.cpp typechecks during CI #46489

Closed
guilhermeleobas opened this issue Oct 16, 2020 · 0 comments
Closed

Enable torch.nn.cpp typechecks during CI #46489

guilhermeleobas opened this issue Oct 16, 2020 · 0 comments
Assignees
@guilhermeleobas
Labels
module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@guilhermeleobas
Copy link
Collaborator

guilhermeleobas commented Oct 16, 2020 •
edited

TestTypeHints.test_run_mypy should pass with [mypy-torch.nn.cpp] deleted from mypy.ini

cc @ezyang @malfet @rgommers @xuzhao9 @gramster
@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Oct 16, 2020
@guilhermeleobas guilhermeleobas self-assigned this Oct 16, 2020
@guilhermeleobas guilhermeleobas mentioned this issue Oct 16, 2020
Closed
@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guilhermeleobas guilhermeleobas

Labels
module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Annotate torch.nn.cpp
2 participants
@guilhermeleobas @ailzhang