Annotate torch.nn.cpp #46490
Annotate torch.nn.cpp #46490
Conversation
💊 CI failures summary and remediationsAs of commit 2e69213c0f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
💊 CI failures summary and remediationsAs of commit 540fcd7 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
guilhermeleobas
requested review from
apaszke,
ezyang,
fmassa,
goldsborough and
soumith
as code owners
guilhermeleobas
requested review from
rgommers and
malfet
and removed request for
ezyang,
soumith,
apaszke,
goldsborough and
fmassa
There was a problem hiding this comment.
Thanks @guilhermeleobas. The one CI failure here is failing on other PRs as well, so this looks about good to go. One minor comment.
| @@ -1044,7 +1044,7 @@ def _compareScalars(self, a, b, *, | |||
| rtol, atol = 0, 0 | |||
| rtol = cast(float, rtol) | |||
| atol = cast(float, atol) | |||
| atol = max(atol, self.precision) | |||
| atol = max(atol, self.precision) if atol is not None else self.precision | |||
There was a problem hiding this comment.
atol cannot be None here anymore, so assert atol is not None on the line right above this one seems like the clearer fix.
gchanan
added
the
triaged
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Fixes #46489