New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect info about overriding torch tensors in version 1.7.0 #47697
Comments
Thanks for pointing this out @jemisjoky, it is indeed an oversight. It looks like |
Haha if I had just looked a bit further down in |
@hameerabbasi did we consciously decide to move to the non-underscored name? |
I've created the docs issue in #48087. |
…ytorch#47842) Summary: Fixes pytorch#47697 Pull Request resolved: pytorch#47842 Reviewed By: smessmer Differential Revision: D24951750 Pulled By: ezyang fbshipit-source-id: df62ec2e52f1c561c864a50bac4abf4a55e4f8e6 (cherry picked from commit 3a2aad9) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
📚 Documentation
I've been working on extending the
torch.Tensor
class, where the information provided in thetorch._overrides
has proven really helpful! After recently upgrading to torch version 1.7.0 however, I noticed that the attribute_overrides
is no longer present intorch
. Two questions/comments about this:torch._overrides
still present somewhere else in the library?torch._overrides
, so should be updated with the correct info.Thank you for your help with this :)
cc @ezyang @gchanan @zou3519 @bdhirsh @hameerabbasi @rgommers @jlin27 @mruberry
The text was updated successfully, but these errors were encountered: