Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nested Tensor] Move nested tensor specific ops to nested namespace #83775

Open
drisspg opened this issue Aug 19, 2022 · 1 comment
Open

[Nested Tensor] Move nested tensor specific ops to nested namespace #83775

drisspg opened this issue Aug 19, 2022 · 1 comment
Assignees
@drisspg @mikaylagawarecki
Labels
module: nestedtensor NestedTensor tag see issue #25032 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@drisspg
Copy link
Contributor

drisspg commented Aug 19, 2022 •
edited by pytorch-bot bot

Summary

Currently all nested tensor specific ops are dumped into the default namespace torch. This issue is used to track work on creating a nested tensor namespace and moving all the nested tensor specific functions that namespace.

cc @cpuhrsch @jbschlosser @bhosmer
@drisspg drisspg added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: nestedtensor NestedTensor tag see issue #25032 labels Aug 19, 2022
@drisspg drisspg self-assigned this Aug 19, 2022
@drisspg drisspg mentioned this issue Aug 19, 2022
Closed
@albanD
Copy link
Collaborator

albanD commented Aug 22, 2022

Note that there is no need to "create" it. You can just start using python_module: in native_functions.yaml

@mikaylagawarecki mikaylagawarecki self-assigned this Aug 24, 2022
@drisspg drisspg changed the title [Nested Tensor] Create nested namespace [Nested Tensor] Move nested tensor specific ops to nested namespace Aug 24, 2022
@mikaylagawarecki mikaylagawarecki mentioned this issue Aug 26, 2022
Closed
mikaylagawarecki added a commit that referenced this issue Aug 30, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
fde5f26 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Aug 30, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
d1f7276 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Aug 30, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
1aa6baa 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Aug 30, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
6d9f89f 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
52024db 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
013eadd 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
8ed7406 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
76f6837 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
b0c50dd 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
b4413c4 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)




[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
0391de6 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)


Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)

[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this issue Sep 8, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
d5a2375 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)


Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Sep 9, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
ee203cc 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)


Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Sep 9, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
ea4ac87 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)


Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Sep 12, 2022
@mikaylagawarecki
Update base for Update on "Add torch.nested namespace"
5f60b02 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)


Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Sep 12, 2022
@mikaylagawarecki
Update on "Add torch.nested namespace"
a1fbfb0 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)


Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this issue Sep 12, 2022
@mikaylagawarecki @pytorchmergebot
Add torch.nested namespace (#84102)
e217b30 
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)

Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148)
Pull Request resolved: #84102
Approved by: https://github.com/drisspg
facebook-github-bot pushed a commit that referenced this issue Sep 12, 2022
@mikaylagawarecki @facebook-github-bot
Add torch.nested namespace (#84102)
061ee6a 
Summary:
Pull Request resolved: #84102

First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.

~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~

[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested)

Test Plan: Imported from OSS

Reviewed By: drisspg

Differential Revision: D39361148

Pulled By: mikaylagawarecki

fbshipit-source-id: add218c3e05a6922735b32c248adde4463dd3f4d
@mikaylagawarecki mikaylagawarecki mentioned this issue Sep 16, 2022
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drisspg drisspg

@mikaylagawarecki mikaylagawarecki

Labels
module: nestedtensor NestedTensor tag see issue #25032 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@albanD @drisspg @mikaylagawarecki