Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TypedStorage and use only UntypedStorage #85302

Open
kurtamohler opened this issue Sep 19, 2022 · 0 comments
Open

Remove TypedStorage and use only UntypedStorage #85302

kurtamohler opened this issue Sep 19, 2022 · 0 comments
Assignees
@kurtamohler
Labels
module: python frontend For issues relating to PyTorch's Python frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@kurtamohler
Copy link
Collaborator

Now that typed storages have been removed from the C++ side and torch.UntypedStorage is in place, we can remove torch.TypedStorage and all of its subclasses, and just use UntypedStorage instead. First, we should add warnings to all of the methods of TypedStorage and its subclasses for at least one whole release.
@kurtamohler kurtamohler added the module: python frontend For issues relating to PyTorch's Python frontend label Sep 19, 2022
@kurtamohler kurtamohler self-assigned this Sep 19, 2022
@kurtamohler kurtamohler mentioned this issue Sep 19, 2022
Closed
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 21, 2022
pytorchmergebot pushed a commit that referenced this issue Nov 8, 2022
@kurtamohler @pytorchmergebot
Deprecate TypedStorage, its derived classes, and all of their public …
ee28b86 
…methods (#85303)

Part of #85302

Pull Request resolved: #85303
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this issue Dec 10, 2022
@kurtamohler @kulinseth
Deprecate TypedStorage, its derived classes, and all of their public …
4212ff9 
…methods (pytorch#85303)

Part of pytorch#85302

Pull Request resolved: pytorch#85303
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtamohler kurtamohler

Labels
module: python frontend For issues relating to PyTorch's Python frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @kurtamohler