Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batching rule for aten::max_pool1d and aten::huber_loss #97558

Closed
Tracked by #97246
yhl48 opened this issue Mar 24, 2023 · 3 comments
Closed
Tracked by #97246

Batching rule for aten::max_pool1d and aten::huber_loss #97558

yhl48 opened this issue Mar 24, 2023 · 3 comments
Labels
module: functorch Pertaining to torch.func or pytorch/functorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@yhl48
Copy link
Contributor

yhl48 commented Mar 24, 2023 •
edited by pytorch-bot bot

馃殌 The feature, motivation and pitch

Related to pytorch/functorch#1088.

UserWarning: There is a performance drop because we have not yet implemented the batching rule for aten::max_pool1d. Please file us an issue on GitHub so that we can prioritize its implementation. (Triggered internally at ../aten/src/ATen/functorch/BatchedFallback.cpp:82.)

UserWarning: There is a performance drop because we have not yet implemented the batching rule for aten::huber_loss. Please file us an issue on GitHub so that we can prioritize its implementation. (Triggered internally at ../aten/src/ATen/functorch/BatchedFallback.cpp:82.)

Would like to help implement these if they have not already been implemented, would appreciate it if some pointers are given!

Alternatives

No response

Additional context

No response

cc @zou3519 @Chillee @samdow @soumith @kshitij12345 @janeyx99
@dagitses dagitses added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: functorch Pertaining to torch.func or pytorch/functorch labels Mar 27, 2023
@zou3519
Copy link
Contributor

zou3519 commented Mar 27, 2023

@yhl48 some pointers are over at https://github.com/pytorch/pytorch/wiki/vmap-Basics if you're interested in giving these a try

@zou3519 zou3519 mentioned this issue Mar 30, 2023
Open
14 tasks
@yhl48
Copy link
Contributor Author

yhl48 commented Apr 4, 2023

Also for aten::smooth_l1_loss

@yhl48 yhl48 mentioned this issue Apr 4, 2023
Closed
pytorchmergebot pushed a commit that referenced this issue Apr 14, 2023
@yhl48 @pytorchmergebot
Add vmap support for torch.nn.functional.smooth_l1_loss (#98357)
298cc5c 
Partially fixes #97246 and #97558.

Pull Request resolved: #98357
Approved by: https://github.com/kshitij12345
@qqaatw
Copy link
Collaborator

qqaatw commented Apr 15, 2023

I took huber_loss here: #99235 :)

@qqaatw qqaatw mentioned this issue Apr 19, 2023
Closed
qqaatw added a commit that referenced this issue Apr 19, 2023
@qqaatw
Update on "[vamp] Add max_pool1d batch_rule"
6965169 
Fixes #97558


[ghstack-poisoned]
qqaatw added a commit that referenced this issue Apr 19, 2023
@qqaatw
Update base for Update on "[vamp] Add max_pool1d batch_rule"
afbf162 
Fixes #97558


[ghstack-poisoned]
qqaatw added a commit that referenced this issue Apr 19, 2023
@qqaatw
Update on "[vamp] Add max_pool1d batch_rule"
0b0f8ca 
Fixes #97558


[ghstack-poisoned]
qqaatw added a commit that referenced this issue Apr 19, 2023
@qqaatw
Update base for Update on "[vamp] Add max_pool1d batch_rule"
244bc8e 
Fixes #97558


[ghstack-poisoned]
qqaatw added a commit that referenced this issue Apr 19, 2023
@qqaatw
Update on "[vamp] Add max_pool1d batch_rule"
59a68a6 
Fixes #97558


[ghstack-poisoned]
ZainRizvi pushed a commit that referenced this issue Apr 19, 2023
@yhl48 @ZainRizvi
Add vmap support for torch.nn.functional.smooth_l1_loss (#98357)
dc7cdc6 
Partially fixes #97246 and #97558.

Pull Request resolved: #98357
Approved by: https://github.com/kshitij12345
qqaatw added a commit that referenced this issue Apr 20, 2023
@qqaatw
Update base for Update on "[vamp] Add max_pool1d batch_rule"
a0fbdf9 
Fixes #97558


[ghstack-poisoned]
qqaatw added a commit that referenced this issue Apr 20, 2023
@qqaatw
Update on "[vamp] Add max_pool1d batch_rule"
845d4ed 
Fixes #97558


[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: functorch Pertaining to torch.func or pytorch/functorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dagitses @zou3519 @qqaatw @yhl48