Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISABLED test_block_addmv_block_size_3_int32_noncontiguous_True_cpu_complex128 (__main__.TestSparseCSRCPU) #97563

Closed
pytorch-bot bot opened this issue Mar 24, 2023 · 6 comments
Closed

DISABLED test_block_addmv_block_size_3_int32_noncontiguous_True_cpu_complex128 (__main__.TestSparseCSRCPU) #97563

pytorch-bot bot opened this issue Mar 24, 2023 · 6 comments
Assignees
@malfet
Labels
module: flaky-tests Problem is a flaky test in CI module: sparse Related to torch.sparse skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 24, 2023 •
edited

Platforms: mac, macos

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 2 workflow(s) with 3 failures and 2 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_block_addmv_block_size_3_int32_noncontiguous_True_cpu_complex128
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.

Test file path: test_sparse_csr.py

cc @alexsamardzic @nikitaved @pearu @cpuhrsch @amjames @bhosmer
@pytorch-bot pytorch-bot bot added module: flaky-tests Problem is a flaky test in CI module: sparse Related to torch.sparse skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Mar 24, 2023
@pytorch-bot
Copy link
Author

pytorch-bot bot commented Mar 24, 2023

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_block_addmv_block_size_3_int32_noncontiguous_True_cpu_complex128 (__main__.TestSparseCSRCPU)
  • Platforms for which to skip the test: mac, macos

Within ~15 minutes, test_block_addmv_block_size_3_int32_noncontiguous_True_cpu_complex128 (__main__.TestSparseCSRCPU) will be disabled in PyTorch CI for these platforms: mac, macos. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, linux, mac, macos, rocm, win, windows.

@cpuhrsch
Copy link
Contributor

@malfet - Is this related to #97353 ?

@malfet
Copy link
Contributor

malfet commented Mar 24, 2023

Yes, indeed. Looking

@malfet malfet self-assigned this Mar 24, 2023
@huydhn
Copy link
Contributor

huydhn commented Mar 24, 2023

Not the same test, but I guess test_sparse_csr.py::TestSparseCSRCPU::test_block_addmv_block_size_2_int32_noncontiguous_False_cpu_float64 is flaky on MacOS for the same root cause, just FYI https://github.com/pytorch/pytorch/actions/runs/4513088922/jobs/7947873485

This was referenced Mar 25, 2023
Closed
Closed
@malfet
Copy link
Contributor

malfet commented Mar 28, 2023

Ok, I've found a pretty funny bug in the test, which indeed rendered detecting the regression almost impossible

@malfet malfet mentioned this issue Mar 28, 2023
Closed
malfet added a commit that referenced this issue Mar 28, 2023
@malfet
Fix sparse addmv ref impl for non-contig tensors
33d1b6f 
Fix logic in `_npref_block_addmm_addmv` that tested op against itself
rather than against dense counterpart.

Print more verbose error message if values differ

Fixes #97629 ,
#97589 and #97563
pytorchmergebot pushed a commit that referenced this issue Mar 28, 2023
@malfet @pytorchmergebot
Fix sparse addmv ref impl for non-contig tensors (#97730)
b443198 
Fix logic in `test_block_addmm` that tested op against itself rather than against dense implementation, by implementing `ref_addvm` function that converts tensor back to dense before multiplying it with vector.

Fix reference implementation by passing stride for vector and result. (Not sure wether it will be more perf efficient to iterate over strided tensor or request a dense copy as MKL implementation does)

Print more verbose error message if values differ.

Fixes #97629 , #97589 ,  #97563

Pull Request resolved: #97730
Approved by: https://github.com/cpuhrsch
@malfet
Copy link
Contributor

malfet commented Mar 28, 2023

Fixed by #97730

@malfet malfet closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malfet malfet

Labels
module: flaky-tests Problem is a flaky test in CI module: sparse Related to torch.sparse skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huydhn @cpuhrsch @malfet