-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TORCH_LOGS=dynamo,aot
shows pattern_matcher.py usage of AotAutograd
#98778
Comments
TORCH_LOGS=dynamo, aot
shows phantom opsTORCH_LOGS=dynamo,aot
shows phantom joint graphs
TORCH_LOGS=dynamo,aot
shows phantom joint graphsTORCH_LOGS=dynamo,aot
shows phantom traced graphs
hmm, i just ran this on master @ ff825de and can't repro.
|
Is there any way that there could be some strange caching behavior? Both @H-Huang and I ran on the AWS cluster. |
I also ran on aws, and iiuc only triton is disk-caching at the moment, so it wouldn't be an explanation for your symptom of phantom dynamo compilations. it could be an actual bug that's fixed on master since the time you ran? |
ok, thanks- i was just gonna say i'd bisect (since i'm oncall this week) but i'll let you do it |
It looks like #97741 introduced the issue, which passes the sanity check since some of those joint graphs look like attention-type computations. |
TORCH_LOGS=dynamo,aot
shows phantom traced graphsTORCH_LOGS=dynamo,aot
shows pattern_matcher.py usage of AotAutograd
The usage of AotAutograd is pattern matching is intended behavior and should only happen once on lazy_init when creating patterns. (And also when the pattern matcher fires.) We should modify logging to hide these by default. |
Is there any workaround for the interim? Debugging is a bit unwieldy with these six extra graphs being printed each time. Edit: Nevermind, I will just make |
You can set |
Fixes #98778 Pull Request resolved: #98936 Approved by: https://github.com/wconstab
Define a file
repro.py
:Run on
viable/strict
:This shows not only the forward graph for
f
but also 6 joint graphs containing ops that should not be related tof
, e.g.bmm
,permute
, etc.Full output
In case this was a build issue, I had @H-Huang also run the script, and he similarly saw these extraneous ops/traced graphs.
cc @ezyang @soumith @msaroufim @wconstab @ngimel @bdhirsh
The text was updated successfully, but these errors were encountered: