remove casts to getter in python_cpp_function.h
#100065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100065
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fbbae1a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dagitses
force-pushed
the
pr100065
branch
2 times, most recently
from
4dc3ea6
to
682345f
Compare
Summary: These were triggering the warning `-Wcast-function-type-strict` and breaking the build on my machine. Test Plan: Rely on CI.
dagitses
added
the
module: autograd
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
albanD
approved these changes
Apr 26, 2023
albanD
added
the
triaged
tfsingh
pushed a commit
to tfsingh/pytorch
that referenced
this pull request
Apr 29, 2023
remove casts to `getter` in python_cpp_function.h Summary: These were triggering the warning `-Wcast-function-type-strict` and breaking the build on my machine. Test Plan: Rely on CI. Pull Request resolved: pytorch#100065 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove casts to
getterin python_cpp_function.hSummary:
These were triggering the warning
-Wcast-function-type-strictandbreaking the build on my machine.
Test Plan: Rely on CI.
cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @lezcano @Varal7