[DDP] Perform input casting in pre forward #100131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that replicate can also have the feature to cast its inputs, which it currently does not. Next diff will change replicate pre hook to support this. Differential Revision: [D45335179](https://our.internmc.facebook.com/intern/diff/D45335179/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100131
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5917c4f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 26, 2023
zhaojuanmao
approved these changes
Apr 27, 2023
|
@pytorchbot merge -f "ci green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is so that replicate can also have the feature to cast its
inputs, which it currently does not. Next diff will change replicate pre hook
to support this.
Differential Revision: D45335179