[FSDP] Subtest sharding strategy in test_fsdp_grad_acc.py #100178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
kwen2501,
wanchaol and
fegin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100178
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit badf1a8: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 27, 2023
Let us make the unit test faster. [ghstack-poisoned]
Let us make the unit test faster. [ghstack-poisoned]
awgu
added
ciflow/trunk
The unit test after takes ~1 minute, so we saved about 2 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
use_orig_params=True, CPU offload,no_sync()#100180Let us make the unit test faster.