Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSDP] Fix use_orig_params=True, CPU offload, no_sync() #100180

Closed
wants to merge 3 commits into from
Closed

[FSDP] Fix use_orig_params=True, CPU offload, no_sync() #100180

wants to merge 3 commits into from

Commits on Apr 27, 2023

  1. [FSDP] Fix use_orig_params=True, CPU offload, no_sync() 

    [ghstack-poisoned]
    @awgu
    awgu committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    00b1807 View commit details
    Browse the repository at this point in the history

  2. Update on "[FSDP] Fix use_orig_params=True, CPU offload, no_sync()" 

    This should fix #98494.

[ghstack-poisoned]
    @awgu
    awgu committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    bb86381 View commit details
    Browse the repository at this point in the history

  3. Update on "[FSDP] Fix use_orig_params=True, CPU offload, no_sync()" 

    This should fix #98494. We follow a similar approach as in past PRs for mismatched dtype or size from running in `no_sync()`.

[ghstack-poisoned]
    @awgu
    awgu committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b4d402e View commit details
    Browse the repository at this point in the history