Not flatten states when use_orig_param is True and sharding is NO_SHARD #100189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
zhaojuanmao
requested review from
mrshenli,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100189
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 90a560f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
zhaojuanmao
added a commit
that referenced
this pull request
Apr 27, 2023
ghstack-source-id: 524ba5724383bd5f4dd7e2a9a6a6fc1de6166d88 Pull Request resolved: #100189
zhaojuanmao
changed the title
awgu
approved these changes
Apr 27, 2023
| ) | ||
| optim = torch.optim.Adam(model.parameters(), lr=1e-2) | ||
|
|
||
| def step(): |
There was a problem hiding this comment.
nit: Curious, why do we define step() here if we only call it once?
There was a problem hiding this comment.
copied from other unit tests:)
There was a problem hiding this comment.
I think it should be OK, it is neat to use a function
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use_orig_param is True and sharding is NO_SHARD, parameters and states are not flattened, so optimizer states should not be flattened as well. The unit test will fail without the fix.
Stack from ghstack (oldest at bottom):