Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] masked_scatter_: non-contiguous self #100232

Closed
wants to merge 2 commits into from
Closed

[fix] masked_scatter_: non-contiguous self #100232

wants to merge 2 commits into from

Conversation

kshitij12345
Copy link
Collaborator

Fixes #99638

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 28, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100232

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f1e2b7c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kshitij12345
kshitij12345 commented Apr 28, 2023
View reviewed changes
aten/src/ATen/native/TensorAdvancedIndexing.cpp
@@ -2372,6 +2372,8 @@ Tensor & masked_scatter__cpu(Tensor& self, const Tensor & mask, const Tensor & s
.set_check_mem_overlap(false)
.check_all_same_dtype(false)
.resize_outputs(false)
// order of indexing matters
.enforce_linear_iteration()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should affect the perf for contiguous cases.

@kshitij12345 kshitij12345 marked this pull request as ready for review April 28, 2023 12:24
ngimel
ngimel approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@ngimel
Copy link
Collaborator

ngimel commented Apr 28, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 28, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@kshitij12345 kshitij12345 added the topic: bug fixes topic category label Apr 28, 2023
@ngimel ngimel added the release notes: intel release notes category label Apr 28, 2023
@ngimel
Copy link
Collaborator

ngimel commented Apr 28, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: intel release notes category topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect gradient for masked_select when inputs are non-contiguous
4 participants
@kshitij12345 @ngimel @pytorchmergebot @pytorchbot