Check inputs have same dtype in addmm_impl_cpu_ even if input has zero numel #100274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
soulitzer
requested review from
lezcano,
nikitaved and
IvanYashchuk
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100274
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ad898d7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soulitzer
added a commit
that referenced
this pull request
Apr 28, 2023
ghstack-source-id: 2c869e722d1f975bc80ddaa862f8fdc64ca60690 Pull Request resolved: #100274
soulitzer
changed the title
…put has zero numel" Fixes #99226 When an inputs has zero numel, addmm_impl_cpu_'s check that the inputs have the same dtype are bypassed. This PR adds a check before the early return. [ghstack-poisoned]
soulitzer
added a commit
that referenced
this pull request
Apr 28, 2023
ghstack-source-id: 6ba072d6a24cebc866c60030669a07af4a8752eb Pull Request resolved: #100274
|
Nah that's fine, even if there were (e.g. alpha=0) we could error out. |
ngimel
approved these changes
Apr 28, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
soulitzer
added a commit
to soulitzer/pytorch
that referenced
this pull request
May 2, 2023
… build failures Summary: This diff is reverting D45446149 D45446149: Check inputs have same dtype in addmm_impl_cpu_ even if input has zero numel (pytorch#100274) by soulitzer has been identified to be causing the following test or build failures: Tests affected: - [caffe2/torch/fb/model_transform/splitting/tests:utils_test - test_maybe_fix_dtype_errors (caffe2.torch.fb.model_transform.splitting.tests.utils_test.UtilsTest)](https://www.internalfb.com/intern/test/844425018399076/) Here's the Multisect link: https://www.internalfb.com/multisect/1972447 Here are the tasks that are relevant to this breakage: We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it. If you believe this diff has been generated in error you may Commandeer and Abandon it. Test Plan: NA Reviewed By: soulitzer Differential Revision: D45471651 fbshipit-source-id: 8440285bfe4a4fcb808da74663ff818478b9b8e0
This was referenced May 3, 2023
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #99226
When an inputs has zero numel, addmm_impl_cpu_'s check that the inputs have the same dtype are bypassed. This PR adds a check before the early return.