Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Diagnostic 'log' and 'log_and_raise_if_error' #100407

Closed
wants to merge 7 commits into from
Closed

[ONNX] Diagnostic 'log' and 'log_and_raise_if_error' #100407

wants to merge 7 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 1, 2023 •
edited by pytorchmergebot

@BowenBao BowenBao mentioned this pull request May 1, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented May 1, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100407

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0139807:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BowenBao BowenBao mentioned this pull request May 1, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 1, 2023
This was referenced May 1, 2023
Closed
Closed
BowenBao added a commit that referenced this pull request May 1, 2023
@BowenBao
[ONNX] Diagnostic 'log' and 'log_and_raise_if_error'
69549b6 
ghstack-source-id: c445bb98c057ce850d8b89d14aaee7d9b3e6b97a
Pull Request resolved: #100407
BowenBao added a commit that referenced this pull request May 1, 2023
@BowenBao
[ONNX] Diagnostic 'log' and 'log_and_raise_if_error'
42c77e5 
ghstack-source-id: b1ba434abf27b93f5113e28e7a4a65a1b9500d2f
Pull Request resolved: #100407
@BowenBao BowenBao added module: onnx Related to torch.onnx topic: new features topic category labels May 1, 2023
@BowenBao BowenBao mentioned this pull request May 2, 2023
Closed
BowenBao added a commit to BowenBao/pytorch that referenced this pull request May 4, 2023
@BowenBao
[ONNX] Diagnostic 'log' and 'log_and_raise_if_error'
3300155 
ghstack-source-id: b1ba434abf27b93f5113e28e7a4a65a1b9500d2f
Pull Request resolved: pytorch#100407
@thiagocrepaldi thiagocrepaldi self-requested a review May 9, 2023 16:50
@BowenBao BowenBao marked this pull request as ready for review May 10, 2023 17:12
@BowenBao BowenBao requested a review from abock as a code owner May 10, 2023 17:12
@BowenBao BowenBao added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2023
@titaiwangms
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/245/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/100407)

pytorchmergebot pushed a commit that referenced this pull request May 11, 2023
@BowenBao
[ONNX] Diagnostic 'log' and 'log_and_raise_if_error'
ae2287e 
ghstack-source-id: b0598bd8bd68f96917582c54bfe66a5afda5793d
Pull Request resolved: #100407

patch previous pr
@titaiwangms titaiwangms self-assigned this May 15, 2023
@titaiwangms
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@titaiwangms
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jcaip pushed a commit that referenced this pull request May 23, 2023
@titaiwangms @jcaip
[ONNX] Diagnostic 'log' and 'log_and_raise_if_error' (#100407)
9fa30ff 
Pull Request resolved: #100407
Approved by: https://github.com/thiagocrepaldi
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/245/head branch June 8, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi

@abock abock Awaiting requested review from abock

Assignees

@titaiwangms titaiwangms

Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BowenBao @titaiwangms @pytorchmergebot @thiagocrepaldi @pytorchbot