Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataPipe] Update docstring for functional form of DataPipes #100446

Closed
wants to merge 11 commits into from
Closed

[DataPipe] Update docstring for functional form of DataPipes #100446

wants to merge 11 commits into from

Commits on May 18, 2023

  1. Update docstring for functional form of IterDataPipes 

    Copy the docstring from IterDataPipe classes to their functional form. Xref pytorch/data#792.
    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    24e7e3d View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    6278c9d View commit details
    Browse the repository at this point in the history

  3. Add regression test to check correctness of DataPipe functional form 

    Ensure that the functional form of IterDataPipe and MapDataPipe contains the proper docstring copied over from the class form.
    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    679156b View commit details
    Browse the repository at this point in the history

  4. Remove unzip test 

    UnZipperMapDataPipe is only in https://github.com/pytorch/data/blob/v0.6.0/torchdata/datapipes/map/util/unzipper.py#L16-L17 and not pytorch/pytorch repo.
    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4b86a3a View commit details
    Browse the repository at this point in the history

  5. Debug failing test_docstring with print statements

    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1a32296 View commit details
    Browse the repository at this point in the history

  6. Delete extra space

    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    05aa283 View commit details
    Browse the repository at this point in the history

  7. Tweak debugging print statements

    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1ce0ca1 View commit details
    Browse the repository at this point in the history

  8. Set forceload=True in pydoc.render_doc 

    Force reload the module from disk to see if it helps with the test.
    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    fc82cb9 View commit details
    Browse the repository at this point in the history

  9. Make test_docstring compatible with Python 3.8

    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b9c79c1 View commit details
    Browse the repository at this point in the history

  10. Remove debugging assert statements 

    Reverts 426e244
    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8457423 View commit details
    Browse the repository at this point in the history

  11. Apply patch for Python 3.8 on TestFunctionalMapDataPipe.test_docstring 

    Same as 52be9e1  but for MapDataPipe
    @weiji14 @pytorchmergebot
    weiji14 authored and pytorchmergebot committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0c6a6c8 View commit details
    Browse the repository at this point in the history