Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Docs for writing ATen IR passes + FX Pattern matching #100577

Closed
wants to merge 4 commits into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented May 3, 2023

I'm not really sure where to put this...maybe just link it somewhere in torch.compile docs?

@angelayi angelayi requested a review from msaroufim May 3, 2023 20:42
@pytorch-bot
Copy link

pytorch-bot bot commented May 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100577

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit 2c5ed2c:

BROKEN TRUNK - The following job failed but were present on the merge base db4572d:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label May 3, 2023
@msaroufim
Copy link
Member

msaroufim commented May 3, 2023

Yup this is a perfectly fine place just make sure to also link to it here https://github.com/pytorch/pytorch/blob/main/docs/source/index.rst

Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reaally timely and thank you was super clear to read

Just a minor nit on the index to make it render on the homepage as well

@angelayi
Copy link
Contributor Author

angelayi commented May 4, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 4, 2023
@angelayi angelayi mentioned this pull request May 4, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: windows-binary-libtorch-release / libtorch-cpu-shared-with-deps-release-test

Details for Dev Infra team Raised by workflow job

@angelayi
Copy link
Contributor Author

angelayi commented May 4, 2023

@pytorchbot merge -f "ily cat 🥺"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request docs-hackathon Merged release notes: fx release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants