Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages in THPVariable_set_grad #100683

Closed
wants to merge 5 commits into from
Closed

Improve error messages in THPVariable_set_grad #100683

wants to merge 5 commits into from

Commits on May 8, 2023

  1. Add error check for matching dtypes in THPVariable_set_grad

    @kiersten-stokes
    kiersten-stokes committed May 8, 2023
    Configuration menu
    Copy the full SHA
    8ec74a9 View commit details
    Browse the repository at this point in the history

  2. Fix linting

    @kiersten-stokes
    kiersten-stokes committed May 8, 2023
    Configuration menu
    Copy the full SHA
    c2cc683 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Update message according to review

    @kiersten-stokes
    kiersten-stokes committed May 9, 2023
    Configuration menu
    Copy the full SHA
    af9a36c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Add additional TORCH_CHECK asserts

    @kiersten-stokes
    kiersten-stokes committed May 10, 2023
    Configuration menu
    Copy the full SHA
    fb00594 View commit details
    Browse the repository at this point in the history

  2. Use type_equal instead of pure layout comparison for remaining case

    @kiersten-stokes
    kiersten-stokes committed May 10, 2023
    Configuration menu
    Copy the full SHA
    6bb414f View commit details
    Browse the repository at this point in the history