Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSDP][state_dict] Restore the state_dict_config for NO_SHARD #100855

Closed
wants to merge 6 commits into from
Closed

[FSDP][state_dict] Restore the state_dict_config for NO_SHARD #100855

wants to merge 6 commits into from

Commits on May 8, 2023

  1. [FSDP] Restore the state_dict_config for NO_SHARD 

    Any change to the user configurations should be temporary. This PR fixes the issue when NO_SHARD state_dict/load_state_dict is called, the state_dict_config and state_dict_type are changed permanently.

Differential Revision: [D45593313](https://our.internmc.facebook.com/intern/diff/D45593313/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D45593313/)!

[ghstack-poisoned]
    @fegin
    fegin committed May 8, 2023
    Configuration menu
    Copy the full SHA
    aefd3a4 View commit details
    Browse the repository at this point in the history

  2. Update on "[FSDP] Restore the state_dict_config for NO_SHARD" 

    Any change to the user configurations should be temporary. This PR fixes the issue when NO_SHARD state_dict/load_state_dict is called, the state_dict_config and state_dict_type are changed permanently.

Differential Revision: [D45593313](https://our.internmc.facebook.com/intern/diff/D45593313/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D45593313/)!

[ghstack-poisoned]
    @fegin
    fegin committed May 8, 2023
    Configuration menu
    Copy the full SHA
    0a236ae View commit details
    Browse the repository at this point in the history

  3. Update on "[FSDP][state_dict] Restore the state_dict_config for NO_SH… 

    …ARD"

Any change to the user configurations should be temporary. This PR fixes the issue when NO_SHARD state_dict/load_state_dict is called, the state_dict_config and state_dict_type are changed permanently.

Differential Revision: [D45593313](https://our.internmc.facebook.com/intern/diff/D45593313/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D45593313/)!

[ghstack-poisoned]
    @fegin
    fegin committed May 8, 2023
    Configuration menu
    Copy the full SHA
    4e4b2ec View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Update on "[FSDP][state_dict] Restore the state_dict_config for NO_SH… 

    …ARD"

Any change to the user configurations should be temporary. This PR fixes the issue when NO_SHARD state_dict/load_state_dict is called, the state_dict_config and state_dict_type are changed permanently.

Differential Revision: [D45593313](https://our.internmc.facebook.com/intern/diff/D45593313/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D45593313/)!

[ghstack-poisoned]
    @fegin
    fegin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    4a15f14 View commit details
    Browse the repository at this point in the history

  2. Update on "[FSDP][state_dict] Restore the state_dict_config for NO_SH… 

    …ARD"

Any change to the user configurations should be temporary. This PR fixes the issue when NO_SHARD state_dict/load_state_dict is called, the state_dict_config and state_dict_type are changed permanently.

Differential Revision: [D45593313](https://our.internmc.facebook.com/intern/diff/D45593313/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D45593313/)!

[ghstack-poisoned]
    @fegin
    fegin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    7a9ccac View commit details
    Browse the repository at this point in the history

  3. Update on "[FSDP][state_dict] Restore the state_dict_config for NO_SH… 

    …ARD"

Any change to the user configurations should be temporary. This PR fixes the issue when NO_SHARD state_dict/load_state_dict is called, the state_dict_config and state_dict_type are changed permanently.

Differential Revision: [D45593313](https://our.internmc.facebook.com/intern/diff/D45593313/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D45593313/)!

[ghstack-poisoned]
    @fegin
    fegin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    4d43a7d View commit details
    Browse the repository at this point in the history