Wrap more constraint violation cases to UserError #100897
Conversation
Summary: As titled Test Plan: CI Differential Revision: D45666627 fbshipit-source-id: adc6aac26eee5116acfcee86b5c9486434b46510
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100897
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 4e3a623: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D45666627 |
guangy10
added
keep-going
| except GuardOnDataDependentSymNode as e: | ||
| raise UserError( | ||
| UserErrorType.ANTI_PATTERN, | ||
| f"Consider annotating your code using constrain_as_*(). {str(e)}") |
There was a problem hiding this comment.
Can you please link to an exportdb example? Or do you plan to do it separately?
There was a problem hiding this comment.
Let me see if we have one for it in the export db. @zhxchen17 do you know which one to use?
There was a problem hiding this comment.
It looks like we don't have one yet. Let's do it separately
|
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
Verified the failed test works locally. @pytorchbot merge -ic |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-bionic-py3.8-clang9 / test (dynamo, 1, 2, linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
This pull request has been merged in 0e08a9b. |
Cases covered in this PR:
constrain_as_*()when trying to export with data-dependent operationsDifferential Revision: D45666627
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire