Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c10d] Figure out device to use for object collectives #100954

Closed
wants to merge 10 commits into from

Conversation

huihoaan
Copy link
Contributor

@huihoaan huihoaan commented May 9, 2023

Fixes #97938

this pr is clone from #100238, which is important to me. But
@kwen2501 has not resolved the confliction. So, this pr is submitted to resolve the confliction.
the only confliction is distributed_c10d.py:2653

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100954

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit adc42c3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label May 9, 2023
@huihoaan
Copy link
Contributor Author

huihoaan commented May 9, 2023

@H-Huang can you give a approve? Or let @kwen2501 modify in his pr

@huihoaan huihoaan changed the title Object coll device [c10d] Figure out device to use for object collectives May 9, 2023
@huihoaan
Copy link
Contributor Author

huihoaan commented May 9, 2023

@pytorchbot -ic

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -ic

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 10, 2023
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for rebasing the PR! LGTM!

@kwen2501
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: distributed (c10d) release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom device and custom backend for Dispatching PyTorch Distributed Collectives
5 participants