Prevent pattern matches across mutation ops in inductor pre-grad FX passes

[williamwen42]

Stack from ghstack (oldest at bottom):

• -> Prevent pattern matches across mutation ops in inductor pre-grad FX passes #101144

Per #101124

cc @soumith @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101144

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4a5b76f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[williamwen42]

Running pytest test/inductor now takes significantly longer. Runtime increased to 10788.64s from 1691.55s.

[jansel]

Running pytest test/inductor now takes significantly longer. Runtime increased to 10788.64s from 1691.55s.

That is weird. You could disable this for joint_graph and post_grad, and only turn it on for the pre-grad graph.

[williamwen42]

Is there an existing method to do this, or do I just add the mutation check directly to the existing passes in pre_grad.py?

[jansel]

Is there an existing method to do this, or do I just add the mutation check directly to the existing passes in pre_grad.py?

You would need to add a flag (or a mode).

[williamwen42]

Inductor unittests don't seem to be taking substantially longer anymore.

[williamwen42]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here