Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPS] Rename metalIndexingFunction to metalIndexingPSO #101156

Closed
wants to merge 1 commit into from

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented May 11, 2023

Stack from ghstack (oldest at bottom):

Rename to reflect its return type.

cc @DenisVieriu97

@qqaatw qqaatw requested a review from kulinseth as a code owner May 11, 2023 05:11
@pytorch-bot
Copy link

pytorch-bot bot commented May 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101156

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3290fb6:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels May 11, 2023
qqaatw added a commit that referenced this pull request May 11, 2023
ghstack-source-id: feb8b517a8b6672f6e2da0192e0293e56ed7957a
Pull Request resolved: #101156
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@qqaatw
Copy link
Collaborator Author

qqaatw commented May 11, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 11, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/qqaatw/30/head branch June 8, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants