[pt2] add meta for linalg_ldl_solve
#101367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101367
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 777e564: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 14, 2023
nkaretnikov
added a commit
that referenced
this pull request
May 14, 2023
ghstack-source-id: 1648d8fe93f0f6f48932540f08ab7a3a6073df59 Pull Request resolved: #101367
nkaretnikov
added
ciflow/trunk
|
Part of this stack because it unlocks tests next to the prev PR in the stack. |
nkaretnikov
commented
May 14, 2023
| device=B.device, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
See TORCH_META_FUNC(linalg_ldl_solve) in core.
nkaretnikov
commented
May 14, 2023
| check( | ||
| LD.dtype == B.dtype, | ||
| lambda: f"torch.linalg.ldl_solve: LD dtype {LD.dtype} does not match b dtype {B.dtype}", | ||
| ) |
There was a problem hiding this comment.
linearSolveCheckInputs already has a dtype check
nkaretnikov
commented
May 14, 2023
| f"torch.linalg.ldl_solve: Expected B to have at least 2 dimensions, " | ||
| f"but it has {B.ndim} dimensions instead" | ||
| ), | ||
| ) |
There was a problem hiding this comment.
This ndim check will never be reached because self.size(-2) is already checked in linearSolveCheckInputs
This was referenced May 14, 2023
lezcano
approved these changes
May 15, 2023
PaliC
added
the
ciflow/periodic
jcaip
pushed a commit
that referenced
this pull request
May 23, 2023
Pull Request resolved: #101367 Approved by: https://github.com/lezcano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
linalg_lu_factor_ex#101375SymIntsupport forlinalg_lu#101372linalg_ldl_solve#101367linalg_ldl_factor_ex#101362SymIntsupport forlinalg_householder_product#101315