Revert torch.fx.interpreter error printing change #101462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently this is breaking internal peeps and I don't care enough to keep it. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101462
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 02e5823: NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
May 15, 2023
Apparently this is breaking internal peeps and I don't care enough to keep it. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 3a821eb85a5778e55287eb2307545b8daafcc955 Pull Request resolved: #101462
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
wushirong
approved these changes
May 15, 2023
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following: |
ngimel
approved these changes
May 16, 2023
voznesenskym
approved these changes
May 16, 2023
|
@pytorchbot merge -f "unrelated failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jcaip
pushed a commit
that referenced
this pull request
May 23, 2023
Apparently this is breaking internal peeps and I don't care enough to keep it. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #101462 Approved by: https://github.com/wushirong, https://github.com/ngimel, https://github.com/voznesenskym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Apparently this is breaking internal peeps and I don't care enough
to keep it.
Signed-off-by: Edward Z. Yang ezyang@meta.com