Commits on May 16, 2023

1. work around precision error in constraint solver …

   In #101307 we tried to fix #101093 using `nsimplify` to convert floats into rationals, but the fix is not reliable: it is possible for `nsimplify` to pick constants that don't work.
   
   Currently, constraint solving is only used by `export`, but constraints are added in all modes. This means that we can hit this issue even in non-`export` modes. This diff works around this issue for such modes by delaying raising such failures until constraint solving.
   
   Differential Revision: [D45922797](https://our.internmc.facebook.com/intern/diff/D45922797/)
   
   [ghstack-poisoned]

   

   avikchaudhuri committed May 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 0839d5c
   • Browse repository at this point

   Copy the full SHA

   0839d5c View commit details

   Browse the repository at this point in the history