Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvement on the decomposition of upsample_bilinear #101682

Closed
wants to merge 1 commit into from
Closed

Minor improvement on the decomposition of upsample_bilinear #101682

wants to merge 1 commit into from

Conversation

lezcano
Copy link
Collaborator

@lezcano lezcano commented May 17, 2023 •
edited

Stack from ghstack (oldest at bottom):

This is how it's done in core.

@pytorch-bot
Copy link

pytorch-bot bot commented May 17, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101682

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 6c3d80c:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lezcano added a commit that referenced this pull request May 17, 2023
@lezcano
Minor improvement on the decomposition of upsample_bilinear
c0d00ad 
As per title

ghstack-source-id: 2e2349bea882327f41db90854821d617ccd620c0
Pull Request resolved: #101682
@lezcano lezcano requested a review from ngimel May 17, 2023 10:30
@lezcano
Copy link
Collaborator Author

lezcano commented May 18, 2023

The failure is unrelated.

@lezcano
Copy link
Collaborator Author

lezcano commented May 18, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda11.8-py3.10-gcc7-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@lezcano
Copy link
Collaborator Author

lezcano commented May 18, 2023

@pytorchbot merge -f "unrelated error"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jcaip pushed a commit that referenced this pull request May 23, 2023
@lezcano @jcaip
Minor improvement on the decomposition of upsample_bilinear (#101682)
48abf71 
This is how it's done in core.
Pull Request resolved: #101682
Approved by: https://github.com/ngimel
@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/197/head branch June 8, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: inductor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lezcano @pytorchmergebot @ngimel @pytorchbot