[Pytorch] Add Vulkan support for aten::unsqueeze for 2d to 3d #101719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
ciflow/periodic
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101719
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 304c599: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D45893511 |
|
/easycla |
lucylq
added a commit
to lucylq/pytorch
that referenced
this pull request
May 17, 2023
…h#101719) Summary: Pull Request resolved: pytorch#101719 Unsqueeze operator: https://pytorch.org/docs/stable/generated/torch.unsqueeze.html#torch.unsqueeze Test Plan: Unsqueeze tests: https://www.internalfb.com/phabricator/paste/view/P738187802 ``` lfq@lfq-mbp fbsource % buck run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*unsqueeze*" Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 15.0 sec (100%) 455/455 jobs, 2/455 updated Total time: 15.0 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *unsqueeze* [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.unsqueeze_dim0 [ OK ] VulkanAPITest.unsqueeze_dim0 (96 ms) [ RUN ] VulkanAPITest.unsqueeze_dim1 [ OK ] VulkanAPITest.unsqueeze_dim1 (2 ms) [ RUN ] VulkanAPITest.unsqueeze_dim2 [ OK ] VulkanAPITest.unsqueeze_dim2 (3 ms) [----------] 3 tests from VulkanAPITest (101 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (101 ms total) [ PASSED ] 3 tests. ``` All tests: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 https://www.internalfb.com/phabricator/paste/view/P738255852 Reviewed By: SS-JIA Differential Revision: D45893511 fbshipit-source-id: 6875e1dcebc928282d8d6a2c795d3167e1dfb2cd
|
This pull request was exported from Phabricator. Differential Revision: D45893511 |
|
This pull request was exported from Phabricator. Differential Revision: D45893511 |
lucylq
added a commit
to lucylq/pytorch
that referenced
this pull request
May 17, 2023
…h#101719) Summary: Pull Request resolved: pytorch#101719 Unsqueeze operator: https://pytorch.org/docs/stable/generated/torch.unsqueeze.html#torch.unsqueeze Test Plan: Unsqueeze tests: https://www.internalfb.com/phabricator/paste/view/P738187802 ``` lfq@lfq-mbp fbsource % buck run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*unsqueeze*" Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 15.0 sec (100%) 455/455 jobs, 2/455 updated Total time: 15.0 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *unsqueeze* [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.unsqueeze_dim0 [ OK ] VulkanAPITest.unsqueeze_dim0 (96 ms) [ RUN ] VulkanAPITest.unsqueeze_dim1 [ OK ] VulkanAPITest.unsqueeze_dim1 (2 ms) [ RUN ] VulkanAPITest.unsqueeze_dim2 [ OK ] VulkanAPITest.unsqueeze_dim2 (3 ms) [----------] 3 tests from VulkanAPITest (101 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (101 ms total) [ PASSED ] 3 tests. ``` All tests: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 https://www.internalfb.com/phabricator/paste/view/P738255852 Reviewed By: SS-JIA Differential Revision: D45893511 fbshipit-source-id: 18fd8808d9dfcda8a8e50e0234252f822f810662
lucylq
added a commit
to lucylq/pytorch
that referenced
this pull request
May 18, 2023
…h#101719) Summary: Pull Request resolved: pytorch#101719 Unsqueeze operator: https://pytorch.org/docs/stable/generated/torch.unsqueeze.html#torch.unsqueeze Test Plan: Unsqueeze tests: https://www.internalfb.com/phabricator/paste/view/P738187802 ``` lfq@lfq-mbp fbsource % buck run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*unsqueeze*" Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 15.0 sec (100%) 455/455 jobs, 2/455 updated Total time: 15.0 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *unsqueeze* [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.unsqueeze_dim0 [ OK ] VulkanAPITest.unsqueeze_dim0 (96 ms) [ RUN ] VulkanAPITest.unsqueeze_dim1 [ OK ] VulkanAPITest.unsqueeze_dim1 (2 ms) [ RUN ] VulkanAPITest.unsqueeze_dim2 [ OK ] VulkanAPITest.unsqueeze_dim2 (3 ms) [----------] 3 tests from VulkanAPITest (101 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (101 ms total) [ PASSED ] 3 tests. ``` All tests: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 https://www.internalfb.com/phabricator/paste/view/P738255852 Reviewed By: SS-JIA Differential Revision: D45893511 fbshipit-source-id: 1a69b1ba8ec50aae5492548e61a565ac20fb7dc6
|
This pull request was exported from Phabricator. Differential Revision: D45893511 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45893511 |
lucylq
added a commit
to lucylq/pytorch
that referenced
this pull request
May 18, 2023
…h#101719) Summary: Pull Request resolved: pytorch#101719 Unsqueeze operator: https://pytorch.org/docs/stable/generated/torch.unsqueeze.html#torch.unsqueeze Test Plan: Unsqueeze tests: https://www.internalfb.com/phabricator/paste/view/P738187802 ``` lfq@lfq-mbp fbsource % buck run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*unsqueeze*" Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 15.0 sec (100%) 455/455 jobs, 2/455 updated Total time: 15.0 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *unsqueeze* [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.unsqueeze_dim0 [ OK ] VulkanAPITest.unsqueeze_dim0 (96 ms) [ RUN ] VulkanAPITest.unsqueeze_dim1 [ OK ] VulkanAPITest.unsqueeze_dim1 (2 ms) [ RUN ] VulkanAPITest.unsqueeze_dim2 [ OK ] VulkanAPITest.unsqueeze_dim2 (3 ms) [----------] 3 tests from VulkanAPITest (101 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (101 ms total) [ PASSED ] 3 tests. ``` All tests: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 https://www.internalfb.com/phabricator/paste/view/P738255852 Reviewed By: SS-JIA Differential Revision: D45893511 fbshipit-source-id: cb856e02465c606b6046d826f24cb3ef9cece739
SS-JIA
approved these changes
May 22, 2023
…h#101719) Summary: bypass-github-export-checks Pull Request resolved: pytorch#101719 Unsqueeze operator: https://pytorch.org/docs/stable/generated/torch.unsqueeze.html#torch.unsqueeze Test Plan: Unsqueeze tests: https://www.internalfb.com/phabricator/paste/view/P738187802 ``` lfq@lfq-mbp fbsource % buck run --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 -- --gtest_filter="*unsqueeze*" Downloaded 0/2 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules) Building: finished in 15.0 sec (100%) 455/455 jobs, 2/455 updated Total time: 15.0 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *unsqueeze* [==========] Running 3 tests from 1 test suite. [----------] Global test environment set-up. [----------] 3 tests from VulkanAPITest [ RUN ] VulkanAPITest.unsqueeze_dim0 [ OK ] VulkanAPITest.unsqueeze_dim0 (96 ms) [ RUN ] VulkanAPITest.unsqueeze_dim1 [ OK ] VulkanAPITest.unsqueeze_dim1 (2 ms) [ RUN ] VulkanAPITest.unsqueeze_dim2 [ OK ] VulkanAPITest.unsqueeze_dim2 (3 ms) [----------] 3 tests from VulkanAPITest (101 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (101 ms total) [ PASSED ] 3 tests. ``` All tests: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 https://www.internalfb.com/phabricator/paste/view/P738255852 Reviewed By: SS-JIA Differential Revision: D45893511 fbshipit-source-id: a465ec11b5c1b536bd1a56e0dd8b692fea67e8f8
|
This pull request was exported from Phabricator. Differential Revision: D45893511 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Unsqueeze operator: https://pytorch.org/docs/stable/generated/torch.unsqueeze.html#torch.unsqueeze
Test Plan:
Unsqueeze tests:
https://www.internalfb.com/phabricator/paste/view/P738187802
All tests:
buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac#macosx-arm64
https://www.internalfb.com/phabricator/paste/view/P738255852
Reviewed By: SS-JIA
Differential Revision: D45893511