group constraints by arg #101815
Closed
group constraints by arg #101815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101815
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c68ebbe: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
avikchaudhuri
added a commit
that referenced
this pull request
May 18, 2023
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) ghstack-source-id: 189589736 Pull Request resolved: #101815
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 18, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189595751 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
|
Failing tests would be fixed by #100739 |
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 18, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189622941 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 19, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189646062 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 19, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189662634 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 19, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189695554 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
angelayi
reviewed
May 19, 2023
tugsbayasgalan
approved these changes
May 19, 2023
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 19, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189734399 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 19, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189742576 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 20, 2023
Pull Request resolved: #101815 Before, we would emit a soup of specializations / constraints without any obvious order to guide readability. With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better. ghstack-source-id: 189775144 Differential Revision: [D45995199](https://our.internmc.facebook.com/intern/diff/D45995199/)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Break internal build" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
Can't revert PR that was landed via phabricator as D45995199. Please revert by going to the internal diff and clicking Unland. |
|
@pytorchbot revert -m "Break internal build" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
Can't revert PR that was landed via phabricator as D45995199. Please revert by going to the internal diff and clicking Unland. |
malfet
added a commit
that referenced
this pull request
May 22, 2023
This reverts commit 03de158. Reverted #101815 on behalf of https://github.com/malfet due to it broke ExecuTorch and author was well aware about it"
PaliC
added a commit
that referenced
this pull request
May 22, 2023
This reverts commit 03de158. Reverted #101815 on behalf of https://github.com/malfet due to it broke ExecuTorch and author was well aware about it" [ghstack-poisoned]
PaliC
pushed a commit
that referenced
this pull request
May 22, 2023
This reverts commit 03de158. Reverted #101815 on behalf of https://github.com/malfet due to it broke ExecuTorch and author was well aware about it" ghstack-source-id: 124ef67dcc8edd2a0eda866e5bb8940b89fc2894 Pull Request resolved: #101985
|
@avikchaudhuri I've reverted this PR in 496212f as it broke ExecuTorch internally, which you were are at the time you merged this PR, haven't you? |
|
@malfet Retrying because I couldn't repro the failures internally on latest trunk. The failures were supposed to be fixed by another diff in that train. |
avikchaudhuri
added a commit
that referenced
this pull request
May 22, 2023
Retrying #101815 Differential Revision: [D46076971](https://our.internmc.facebook.com/intern/diff/D46076971/) [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 23, 2023
Retrying #101815 Differential Revision: [D46076971](https://our.internmc.facebook.com/intern/diff/D46076971/) cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Before, we would emit a soup of specializations / constraints without any obvious order to guide readability.
With this diff, we group such results by arg, and add comments preceding each group. Empirically, the results read much better.
Differential Revision: D45995199
cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire