Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPS] Fix embedding cache key #101857

Closed
wants to merge 3 commits into from
Closed

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented May 19, 2023

Stack from ghstack (oldest at bottom):

Fixes #101198

[ghstack-poisoned]
@qqaatw qqaatw requested a review from kulinseth as a code owner May 19, 2023 06:09
@pytorch-bot
Copy link

pytorch-bot bot commented May 19, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101857

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1d14437:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels May 19, 2023
qqaatw added a commit that referenced this pull request May 19, 2023
ghstack-source-id: d73319d91d3ff66d49d5781dd2e65fefaaed1b73
Pull Request resolved: #101857
qqaatw added a commit that referenced this pull request May 19, 2023
ghstack-source-id: 3ba9c3d6cc9cfa7977cbe43f412dad099aef5bad
Pull Request resolved: #101857
@qqaatw qqaatw requested review from malfet and albanD May 20, 2023 12:01
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for catching this.

qqaatw added a commit that referenced this pull request May 21, 2023
ghstack-source-id: 182f82ab6dd9d24bacfc404d2aa5eac24efccbe9
Pull Request resolved: #101857
@qqaatw
Copy link
Collaborator Author

qqaatw commented May 21, 2023

@pytorchbot merge -f "Just added a comment, MPS tests were green previously, lint is green."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/qqaatw/34/head branch June 8, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants