Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resize on meta storage #101988

Closed
wants to merge 5 commits into from
Closed

Support resize on meta storage #101988

wants to merge 5 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented May 22, 2023 •
edited

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@meta.com

@ezyang
Support resize on meta storage
1cec7c3 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 22, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101988

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit b98a0b6:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request May 22, 2023
@ezyang
Support resize on meta storage
3554daa 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 46bf0449a95dbbf32a8b8a82c99bc6b118b448a2
Pull Request resolved: #101988
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label May 22, 2023
albanD
albanD approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the xfail list is updated!

@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category labels May 23, 2023
@ezyang
Update on "Support resize on meta storage"
9d324d1 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 23, 2023
@ezyang
Support resize on meta storage
598e66d 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 8a5a084d2a4055deca0826607ff63106a8d3518e
Pull Request resolved: #101988
@ezyang
Update on "Support resize on meta storage"
ce965ca 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 23, 2023
@ezyang
Support resize on meta storage
05a28c5 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 12701ad34209f7d9485947b8788ba6aad0a9f783
Pull Request resolved: #101988
@ezyang
Copy link
Contributor Author

ezyang commented May 23, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 2, 3, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@ezyang
Update on "Support resize on meta storage"
f1978ff 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 23, 2023
@ezyang
Support resize on meta storage
a57fda0 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: e2c3faa4ca459b26b29ff20b02ca47f82c5aa5ab
Pull Request resolved: #101988
@ezyang
Copy link
Contributor Author

ezyang commented May 23, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@osalpekar
Copy link
Member

This PR seems to be based atop #101949 and #101976 which were reverted. Since those will no longer be landed internally, this PR doesn't patch internally during diff-train import due to merge conflicts. In order to unblock importing the rest of the commits, I'll need to revert this change, and then this would need to be rebased and re-merged. Apologies for the inconvenience.

@osalpekar
Copy link
Member

@pytorchbot revert -m "Need to revert and rebase this in order to unblock train import" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@ezyang your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request May 24, 2023
@pytorchmergebot
Revert "Support resize on meta storage (#101988)"
210fc28 
This reverts commit 7d1ba0a.

Reverted #101988 on behalf of https://github.com/osalpekar due to Need to revert and rebase this in order to unblock train import ([comment](#101988 (comment)))
@ezyang ezyang reopened this May 24, 2023
@github-actions github-actions bot requested review from albanD and bdhirsh May 24, 2023 23:22
@ezyang
Update on "Support resize on meta storage"
b98a0b6 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 25, 2023
@ezyang
Support resize on meta storage
b927e16 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 6db32621c2575a5d7f010dfbe66f8a91438f7441
Pull Request resolved: #101988
@ezyang
Copy link
Contributor Author

ezyang commented May 25, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang
Copy link
Contributor Author

ezyang commented May 25, 2023

This PR didn't conflict at all on master so it's weird it had to be reverted

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2109/head branch June 8, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@albanD albanD Awaiting requested review from albanD

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category Reverted topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ezyang @pytorchmergebot @osalpekar @albanD @bdhirsh