Add mps support for maxpool3d

[Berzeg]

Fixes #100674

Added mps support for forward / backward passes of maxpool3d.

As mentioned in the referenced issue, I'm utilizing the maxpool 4d op that is available from the metal library to achieve this.

cc: @mattiaspaul

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102148

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit 351390b:

NEW FAILURES - The following jobs have failed:

• linux-bionic-cuda11.8-py3.10-gcc7 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh)
• linux-bionic-cuda11.8-py3.10-gcc7-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
• linux-bionic-py3.11-clang9 / test (crossref, 2, 2, linux.2xlarge) (gh)
• linux-bionic-py3.11-clang9 / test (default, 1, 3, linux.2xlarge) (gh)
• linux-bionic-py3.11-clang9 / test (dynamo, 2, 2, linux.2xlarge) (gh)
• linux-bionic-py3.8-clang9 / test (crossref, 2, 2, linux.2xlarge) (gh)
• linux-bionic-py3.8-clang9 / test (default, 1, 3, linux.2xlarge) (gh)
• linux-bionic-py3.8-clang9 / test (dynamo, 2, 2, linux.2xlarge) (gh)
• linux-focal-py3.8-gcc7 / test (default, 2, 3, linux.2xlarge) (gh)
• linux-focal-py3.9-clang7-asan / test (default, 2, 6, linux.4xlarge) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[qqaatw]

Hi, can you please add a test for it in test/test_mps.py?

Since there is an OpInfo for max_pool3d already, you can simply remove the following line and the consistency tests between cpu and mps will run automatically:

pytorch/test/test_mps.py

Line 490 in 8751002

'nn.functional.max_pool3d': None,

[qqaatw]

Also think you need to implement max_pool3d_with_indices* ops and adjust the decomp test in test_decomp.py since in MPS we treat w & w/o indices as separate kernels instead of sharing the same kernel and using CompositeImplicitAutograd. Let me know if you need any help!

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[kulinseth]

Hi, can you please add a test for it in test/test_mps.py?

Since there is an OpInfo for max_pool3d already, you can simply remove the following line and the consistency tests between cpu and mps will run automatically:

pytorch/test/test_mps.py

Line 490 in 8751002

'nn.functional.max_pool3d': None,

@Berzeg , thanks for the PR. Can you address comments from @qqaatw . Please let us know if you need help.

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.