Fix ignored_states when they are passed as generators #102575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
zhaojuanmao
requested review from
mrshenli,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
kiukchung and
d4l3k
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102575
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e0dcac8: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
zhaojuanmao
added a commit
that referenced
this pull request
May 30, 2023
ghstack-source-id: c496dd352b7ffa287313229d44719f800a092cec Pull Request resolved: #102575
zhaojuanmao
changed the title
awgu
approved these changes
May 30, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
May 31, 2023
This PR fixed the case where ignored_states are passed as generators, not List/Set Pull Request resolved: pytorch#102575 Approved by: https://github.com/awgu
shaoyf42
pushed a commit
to shaoyf42/pytorch
that referenced
this pull request
Jun 1, 2023
This PR fixed the case where ignored_states are passed as generators, not List/Set Pull Request resolved: pytorch#102575 Approved by: https://github.com/awgu
alimoezzi
pushed a commit
to alimoezzi/pytorch
that referenced
this pull request
Jun 3, 2023
This PR fixed the case where ignored_states are passed as generators, not List/Set Pull Request resolved: pytorch#102575 Approved by: https://github.com/awgu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the case where ignored_states are passed as generators, not List/Set
Stack from ghstack (oldest at bottom):