Fix sparse windows on CPU with MKL #102604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102604
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4156083 with merge base 6049998 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mantaionut
force-pushed
the
Fix_sparse_windows
branch
4 times, most recently
from
06a2d02
to
987b456
Compare
mantaionut
added
the
ciflow/periodic
mantaionut
force-pushed
the
Fix_sparse_windows
branch
2 times, most recently
from
4eb772e
to
b387cd9
Compare
mantaionut
added
the
ciflow/binaries
mantaionut
force-pushed
the
Fix_sparse_windows
branch
2 times, most recently
from
3769714
to
097ea78
Compare
mantaionut
force-pushed
the
Fix_sparse_windows
branch
2 times, most recently
from
f22be71
to
fc8b4da
Compare
mantaionut
force-pushed
the
Fix_sparse_windows
branch
4 times, most recently
from
85b363a
to
aaf3d35
Compare
mantaionut
force-pushed
the
Fix_sparse_windows
branch
11 times, most recently
from
b2a7af2
to
b72a468
Compare
mantaionut
force-pushed
the
Fix_sparse_windows
branch
9 times, most recently
from
eb8a99d
to
b7a417d
Compare
mantaionut
force-pushed
the
Fix_sparse_windows
branch
from
b7a417d
to
682ebd1
Compare
|
@mantaionut @malfet - Do we still want to move forward with this? |
I would like to move forward. But it also depends on pytorch/builder#1467 for which i had to make additional changes after rebasing. |
Merged builder PR, please remove temporary changes from this PR and merge it |
mantaionut
force-pushed
the
Fix_sparse_windows
branch
2 times, most recently
from
dfabdf7
to
6df47d7
Compare
Added support for intel Sparse on Windows
mantaionut
force-pushed
the
Fix_sparse_windows
branch
from
6df47d7
to
4156083
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Follow up on: #102604 Address this comment: #102604 (comment) Whl metadata for all wheels published to pypi must match, otherwise poetry install will fail see this comment: #88049 (comment) Pull Request resolved: #121014 Approved by: https://github.com/malfet
Lourencom
pushed a commit
to Lourencom/pytorch
that referenced
this pull request
Mar 6, 2024
Follow up on: pytorch#102604 Address this comment: pytorch#102604 (comment) Whl metadata for all wheels published to pypi must match, otherwise poetry install will fail see this comment: pytorch#88049 (comment) Pull Request resolved: pytorch#121014 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97352.
This PR changes the way the linking to intel MKL is done and updating MKL on Windows to mkl-2021.4.0 .
There are for both conda and pip packages MKL version with which you can link dynamically. mkl-devel contains the static versions of the dlls and MKL contains the needed dlls for the runtime. MKL dlls and static libs starting with 2021.4.0 have the version in their names( for MKL 2023 we have mkl_core.2.dll and for 2021.4.0 we have mkl_core.1.dll) so its possible to have multiple versions installed and it will work properly.
For the wheel build, I added dependency for whell MKL and on conda a dependecy for the conda MKL and on libtorch I copied the MKL binaries in libtorch.
In order to test this PR I have to use custom builder pytorch/builder#1467
cc @alexsamardzic @nikitaved @pearu @cpuhrsch @amjames @bhosmer @jcaip @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite