Use safe_is_leaf to test leafness #102706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes one of the problems in #101160 (comment) but I don't have a test case because the full example is fairly difficult to minify. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102706
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 228ea17: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Jun 1, 2023
This fixes one of the problems in #101160 (comment) but I don't have a test case because the full example is fairly difficult to minify. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 6a4e9aa7bb7693d87971caecab7c9c72e9accba8 Pull Request resolved: #102706
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
added
ciflow/trunk
bdhirsh
approved these changes
Jun 1, 2023
bdhirsh
approved these changes
Jun 1, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
github-actions bot
pushed a commit
to smalltalkman/pytorch
that referenced
this pull request
Jun 1, 2023
This fixes one of the problems in pytorch#101160 (comment) but I don't have a test case because the full example is fairly difficult to minify. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#102706 Approved by: https://github.com/bdhirsh
|
looks like it merged in dcf0c5f |
alimoezzi
pushed a commit
to alimoezzi/pytorch
that referenced
this pull request
Jun 3, 2023
This fixes one of the problems in pytorch#101160 (comment) but I don't have a test case because the full example is fairly difficult to minify. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#102706 Approved by: https://github.com/bdhirsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This fixes one of the problems in #101160 (comment)
but I don't have a test case because the full example is fairly
difficult to minify.
Signed-off-by: Edward Z. Yang ezyang@meta.com